Add toggle command to switch between two input sources #5

markdwags · 2026-01-08T23:19:30Z

This pull request adds a new toggle command to the ddcswitch tool, allowing users to easily switch a monitor between two specified input sources. The documentation and help output are updated to reflect this new feature, including usage examples and integration tips for automation and hotkeys.

New Feature: Toggle Command

Added the toggle command to the command router, enabling users to flip a monitor between two input sources automatically. (CommandRouter.cs)
Implemented the ToggleInputResponse record for structured JSON output, and registered it in the JsonContext for serialization. (JsonContext.cs) [1] [2]

Documentation Updates

Updated CHANGELOG.md to document the addition of the toggle command for version 1.0.3.
Expanded the help output (HelpCommand.cs) to include the new toggle command and added example usage lines. [1] [2]
Added detailed usage examples, behavior description, and automation tips for the toggle command in EXAMPLES.md.
Updated README.md with toggle command examples, use cases, and integration scenarios for hotkeys and scripts. [1] [2]

…ntation and examples

Copilot

Pull request overview

This pull request adds a new toggle command to the ddcswitch utility, enabling users to automatically switch a monitor between two specified input sources. The command detects the current input and switches to the alternate one, making it ideal for hotkey automation and scripting scenarios.

Added ToggleCommand with input detection, validation, and switching logic
Extended JSON serialization support with ToggleInputResponse record
Updated documentation across README, EXAMPLES, and help output

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
DDCSwitch/Commands/ToggleCommand.cs	Implements the new toggle command with comprehensive error handling and both JSON and console output formatting
DDCSwitch/Commands/CommandRouter.cs	Integrates the toggle command into the command routing logic
DDCSwitch/JsonContext.cs	Adds `ToggleInputResponse` record for JSON serialization support
DDCSwitch/Commands/HelpCommand.cs	Updates help text to document the toggle command with usage examples
README.md	Documents toggle command usage, behavior, and use cases for hotkeys/automation
EXAMPLES.md	Provides detailed examples including PowerShell scripts and AutoHotkey integration
CHANGELOG.md	Documents the new toggle feature for version 1.0.3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-08T23:24:40Z

DDCSwitch/Commands/ToggleCommand.cs

+        }
+        else
+        {
+            ConsoleOutputFormatter.WriteError(errorMessage);


The error message should include a period at the end for consistency with other commands. In GetCommand and SetCommand, the console error output for this message includes a period: "Monitor '{monitorId}' not found." The JSON output correctly omits the period to match the pattern used throughout the codebase.

Copilot · 2026-01-08T23:24:40Z

DDCSwitch/Commands/ToggleCommand.cs

+        return PerformInputSwitch(monitor, currentInput, targetInput, input1Arg, input2Arg, hasWarning, warningMessage, jsonOutput);
+    }
+
+    private static int PerformInputSwitch(Monitor monitor, uint currentInput, uint targetInput, string input1Arg, string input2Arg, bool hasWarning, string? warningMessage, bool jsonOutput)


The parameters input1Arg and input2Arg are unused in this method. The method uses InputSource.GetName(currentInput) and InputSource.GetName(targetInput) to get the display names instead. These parameters should be removed from the method signature.

Copilot · 2026-01-08T23:24:41Z

DDCSwitch/Commands/ToggleCommand.cs

+        }
+
+        // Perform the input switch
+        return PerformInputSwitch(monitor, currentInput, targetInput, input1Arg, input2Arg, hasWarning, warningMessage, jsonOutput);


The parameters input1Arg and input2Arg are unused by the PerformInputSwitch method. These should be removed from this call and from the method signature.

Copilot · 2026-01-08T23:24:41Z

DDCSwitch/Commands/ToggleCommand.cs

+        return 1;
+    }
+
+    private static int ExecuteToggle(Monitor monitor, uint input1Value, uint input2Value, string input1Arg, string input2Arg, bool jsonOutput)


The parameters input1Arg and input2Arg are only passed through to PerformInputSwitch where they are unused. Since the method uses InputSource.GetName() with the numeric values instead, these string parameters should be removed from this method signature as well.

Copilot · 2026-01-08T23:24:41Z

DDCSwitch/Commands/ToggleCommand.cs

+        }
+
+        // Execute the toggle operation
+        int result = ExecuteToggle(monitor, input1Value, input2Value, input1Arg, input2Arg, jsonOutput);


The parameters input1Arg and input2Arg are unused by ExecuteToggle and its downstream methods. These should be removed from this call and from the method signature.

Copilot · 2026-01-08T23:24:41Z

DDCSwitch/Commands/ToggleCommand.cs

+        }
+        else
+        {
+            ConsoleOutputFormatter.WriteError(errorMessage);


The error message should include a period at the end for consistency with other commands. In GetCommand, SetCommand, and VcpScanCommand, the console error output for this message includes a period: "No DDC/CI capable monitors found." The JSON output correctly omits the period to match the pattern used throughout the codebase.

…t support

… better readability

…ure mapping

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

DDCSwitch/Commands/ToggleCommand.cs

DDCSwitch/NativeMethods.cs

DDCSwitch/EdidParser.cs

README.md

Copilot · 2026-01-09T05:50:08Z

DDCSwitch/Commands/VcpScanCommand.cs

+            foreach (var feature in features.Values)
+            {
+                if (feature.IsSupported)
+                {
+                    supportedFeatures.Add(feature);
+                }
+            }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2026-01-09T05:50:08Z

DDCSwitch/NativeMethods.cs

+            foreach (string mfgKey in displayRoot.GetSubKeyNames())
+            {
+                using var mfgSubKey = displayRoot.OpenSubKey(mfgKey);
+                if (mfgSubKey == null) continue;
+
+                // Try each instance under this manufacturer
+                foreach (string instanceKey in mfgSubKey.GetSubKeyNames())
+                {
+                    using var instanceSubKey = mfgSubKey.OpenSubKey(instanceKey);
+                    if (instanceSubKey == null) continue;
+
+                    // Check if this is an active device
+                    using var deviceParams = instanceSubKey.OpenSubKey("Device Parameters");
+                    if (deviceParams == null) continue;
+
+                    // Read EDID data
+                    var edidData = deviceParams.GetValue("EDID") as byte[];
+                    if (edidData != null && edidData.Length >= 128)
+                    {
+                        // Validate EDID header
+                        if (EdidParser.ValidateHeader(edidData))
+                        {
+                            edidList.Add(edidData);
+                        }
+                    }
+                }
+            }


This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.

Copilot · 2026-01-09T05:50:08Z

DDCSwitch/NativeMethods.cs

+                foreach (string instanceKey in mfgSubKey.GetSubKeyNames())
+                {
+                    using var instanceSubKey = mfgSubKey.OpenSubKey(instanceKey);
+                    if (instanceSubKey == null) continue;
+
+                    // Check if this is an active device
+                    using var deviceParams = instanceSubKey.OpenSubKey("Device Parameters");
+                    if (deviceParams == null) continue;
+
+                    // Read EDID data
+                    var edidData = deviceParams.GetValue("EDID") as byte[];
+                    if (edidData != null && edidData.Length >= 128)
+                    {
+                        // Validate EDID header
+                        if (EdidParser.ValidateHeader(edidData))
+                        {
+                            edidList.Add(edidData);
+                        }
+                    }
+                }


This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.

Copilot · 2026-01-09T05:50:09Z

DDCSwitch/NativeMethods.cs

+                    if (edidData != null && edidData.Length >= 128)
+                    {
+                        // Validate EDID header
+                        if (EdidParser.ValidateHeader(edidData))
+                        {
+                            edidList.Add(edidData);
+                        }
+                    }


These 'if' statements can be combined.

…ata retrieval

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…o-install

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T06:02:08Z

DDCSwitch/Commands/ToggleCommand.cs

+    /// <param name="monitor">Monitor to read current input from</param>
+    /// <param name="jsonOutput">Whether to format output as JSON</param>
+    /// <param name="currentInput">The detected current input value</param>
+    /// <returns>0 on success, 1 on failure</returns>


The documentation comment states this function returns 0 on success or 1 on failure, but the implementation returns 2 for warning conditions. Update the documentation comment to reflect that it can return 0 (success), 1 (hard error), or 2 (warning with fallback).

Suggested change

/// <returns>0 on success, 1 on failure</returns>

/// <returns>

/// 0 on success,

/// 1 on hard error,

/// or 2 on warning with fallback.

/// </returns>

Copilot · 2026-01-09T06:02:08Z

DDCSwitch/Commands/ConsoleOutputFormatter.cs

+        // Calculate approximate month from week number
+        // Week 1-4: January, Week 5-8: February, etc.
+        string? monthName = week switch
+        {
+            >= 1 and <= 4 => "January",
+            >= 5 and <= 8 => "February",
+            >= 9 and <= 13 => "March",
+            >= 14 and <= 17 => "April",
+            >= 18 and <= 22 => "May",
+            >= 23 and <= 26 => "June",
+            >= 27 and <= 30 => "July",
+            >= 31 and <= 35 => "August",
+            >= 36 and <= 39 => "September",
+            >= 40 and <= 43 => "October",
+            >= 44 and <= 48 => "November",
+            >= 49 and <= 53 => "December",
+            _ => null
+        };


The week-to-month conversion is inaccurate. This logic assumes 4 weeks per month, but months have different numbers of weeks. For example, week 13 would be in late March, not the end of March as implied by "March". ISO 8601 week dates don't align with calendar months. Consider either removing the month approximation and just showing the week number, or using a more accurate calculation based on the actual calendar.

Copilot · 2026-01-09T06:02:08Z

DDCSwitch/NativeMethods.cs

+                    if (edidData != null && edidData.Length >= 128)
+                    {
+                        // Validate EDID header
+                        if (EdidParser.ValidateHeader(edidData))
+                        {
+                            edidList.Add(edidData);
+                        }


These 'if' statements can be combined.

Suggested change

if (edidData != null && edidData.Length >= 128)

{

// Validate EDID header

if (EdidParser.ValidateHeader(edidData))

{

edidList.Add(edidData);

}

if (edidData != null && edidData.Length >= 128 && EdidParser.ValidateHeader(edidData))

{

// Valid EDID header

edidList.Add(edidData);

Add toggle command to switch between two input sources; update docume…

12d898d

…ntation and examples

Copilot AI review requested due to automatic review settings January 8, 2026 23:19

Copilot started reviewing on behalf of markdwags January 8, 2026 23:19 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

Add Chocolatey installation instructions to README

3d2c487

markdwags self-assigned this Jan 8, 2026

markdwags added 6 commits January 8, 2026 20:40

Add EDID parsing functionality and update monitor data structure

0ff4ae9

Add EDID information retrieval and display command for monitors

ff1b199

Add info command to display detailed EDID information with JSON outpu…

06e264f

…t support

Refactor manufacture date display to include month name and week number

f7a2556

Enhance monitor details display with structured panels and tables for…

4454b6f

… better readability

Improve error handling and performance in command processing and feat…

7886612

…ure mapping

Copilot AI review requested due to automatic review settings January 9, 2026 05:45

Copilot started reviewing on behalf of markdwags January 9, 2026 05:46 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

markdwags and others added 2 commits January 8, 2026 23:50

Remove outdated examples and improve documentation clarity for EDID d…

fe10fa5

…ata retrieval

Update README.md

4efcd89

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 9, 2026 05:53

Update DDCSwitch/Commands/ToggleCommand.cs

a474f12

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of markdwags January 9, 2026 05:53 View session

markdwags and others added 3 commits January 8, 2026 23:54

Update DDCSwitch/NativeMethods.cs

9fe5f4b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update DDCSwitch/EdidParser.cs

0af6a6d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/fix/choco-install' into fix/choc…

74d1264

…o-install

Copilot AI reviewed Jan 9, 2026

View reviewed changes

markdwags merged commit 0a224bc into main Jan 9, 2026
6 checks passed

markdwags deleted the fix/choco-install branch January 9, 2026 16:46

-    /// <returns>0 on success, 1 on failure</returns>
+    /// <returns>
+    /// 0 on success,
+    /// 1 on hard error,
+    /// or 2 on warning with fallback.
+    /// </returns>

Add toggle command to switch between two input sources #5

Add toggle command to switch between two input sources #5

Uh oh!

Conversation

markdwags commented Jan 8, 2026

New Feature: Toggle Command

Documentation Updates

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants